Small reorderings #199
Open
Small reorderings #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
small_reorderings
branch
2 times, most recently
from
1fa60cd to
9ed975a
Compare
tom93
reviewed
Aug 2, 2024
vmcj
force-pushed
the
small_reorderings
branch
2 times, most recently
from
4daccd5 to
32e35c3
Compare
vmcj
force-pushed
the
small_reorderings
branch
from
32e35c3 to
7aaed08
Compare
tom93
reviewed
Aug 26, 2024
Comment on lines
6
to
8
| # Set up user | ||
| RUN groupadd domjudge -g2004 | ||
| RUN useradd -m domjudge -u2004 -g2004 | ||
|
|
Contributor
There was a problem hiding this comment.
I have a draft in branch queue/check-ownership-across-docker-build-stages (f62e173) to check the UID & GID are the same instead of having to hard-code the values.
vmcj
force-pushed
the
small_reorderings
branch
from
7aaed08 to
de4cd88
Compare
vmcj
force-pushed
the
small_reorderings
branch
from
de4cd88 to
5b31860
Compare
Member
Author
|
@tom93 I've added your commit to this branch, as I think it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to check if CI passes, based on a subset of the suggestions by @tom93 in July.